Ed Sanders [Thu, 10 Jan 2019 13:21:38 +0000 (13:21 +0000)]
Mark jquery.throttle-debounce as deprecated
Bug: T213426
Change-Id: If1c165d479bc7b47f806fa20e103059bffc761f7
jenkins-bot [Wed, 6 Feb 2019 22:24:18 +0000 (22:24 +0000)]
Merge "resources: Update OOjs-Router from v0.1.0 to v0.2.0"
jenkins-bot [Wed, 6 Feb 2019 21:43:35 +0000 (21:43 +0000)]
Merge "resources: Update OOjs-Router from
48302a572 to v0.1.0"
James D. Forrester [Wed, 6 Feb 2019 20:22:03 +0000 (12:22 -0800)]
resources: Update OOjs-Router from v0.1.0 to v0.2.0
Change-Id: Ib6847f7328f28f31141f3ae59f0f9a0f49dbf508
jenkins-bot [Wed, 6 Feb 2019 20:31:19 +0000 (20:31 +0000)]
Merge "Move exceptions JobQueueError to own file"
James D. Forrester [Wed, 6 Feb 2019 19:52:46 +0000 (11:52 -0800)]
resources: Update OOjs-Router from
48302a572 to v0.1.0
Add to foreign resource validation tool.
Change-Id: I06f5b2c258d1e72f2eb6268a6d24824bbe5d19eb
Bartosz Dziewoński [Wed, 6 Feb 2019 12:10:52 +0000 (13:10 +0100)]
.phpcs.xml: Remove ignores for removed files
* includes/compat/normal/UtfNormalUtil.php
Removed in
88ea69f2f7fa33dfc2ab787ed069380f76d4b7ef.
* maintenance/benchmarks/bench_strtr_str_replace.php
Rewritten in
1031825f3b7732fb03fa745bff12e671c2f73d1a.
Change-Id: Ie88fb420e688f11c8a94ecf91cb8b839944d991d
Umherirrender [Wed, 6 Feb 2019 18:39:20 +0000 (19:39 +0100)]
Move exceptions JobQueueError to own file
Change-Id: Ibd67358cb7a14497dce8a3982ceba3b4300bdd65
Roan Kattouw [Thu, 26 Apr 2018 18:23:32 +0000 (11:23 -0700)]
Use PRC_AUTOPATROLLED for rollbacks and revdel
These are automatic, and happen regardless of whether the user
performing the action has patrol-related rights.
Bug: T190408
Bug: T184791
Change-Id: Icd1f3826c378ae759f501d87ffb9988766775b27
Derick Alangi [Mon, 4 Feb 2019 12:45:39 +0000 (13:45 +0100)]
Fix condition if...else in getDB() & PHPDoc comment for getUserDB()
So the conditional check should by default return $this->mDb if it's not
null, so, the else seems not to be needed(?). If we have a database handle
to process the current batch, $this->getDB() will return IMaintainableDatabase
but if it's not available (null), a call to $this->getDB() will return an
instance of \Wikimedia\Rdbms\Database is returned instead.
In accordance with the documentation (phpdoc), update the method getUserDB()
to be compliant with callers return type.
Change-Id: I95f3407dd2ffe8e4a1ad7a70be86b6cf3b65ff50
jenkins-bot [Wed, 6 Feb 2019 01:33:12 +0000 (01:33 +0000)]
Merge "Remove deprecated class SquidUpdate"
jenkins-bot [Wed, 6 Feb 2019 01:12:51 +0000 (01:12 +0000)]
Merge "Improve error handling for wrong autoloader permissions"
jenkins-bot [Wed, 6 Feb 2019 00:57:41 +0000 (00:57 +0000)]
Merge "Fix message documentation to refer to Special:Block page"
jenkins-bot [Wed, 6 Feb 2019 00:51:12 +0000 (00:51 +0000)]
Merge "objectcache: Fixes WinCache increment losing TTL."
jenkins-bot [Wed, 6 Feb 2019 00:49:15 +0000 (00:49 +0000)]
Merge "rdbms: lower value of MAX_LAG_DEFAULT to 6"
jenkins-bot [Wed, 6 Feb 2019 00:46:39 +0000 (00:46 +0000)]
Merge "rdbms: move "maxLag" parameter up to LBFactory and add comments"
jenkins-bot [Wed, 6 Feb 2019 00:46:34 +0000 (00:46 +0000)]
Merge "Add test for User::isBlockedFrom"
Aaron Schulz [Sun, 27 Jan 2019 22:15:13 +0000 (14:15 -0800)]
rdbms: lower value of MAX_LAG_DEFAULT to 6
This matches the "max lag" value used in the server configuration
array for WMF sites for a long time.
Change-Id: Ic2e82a8cc0932e7cf28ababc2eb0849406da06ef
jenkins-bot [Wed, 6 Feb 2019 00:17:09 +0000 (00:17 +0000)]
Merge "Follow-up
dbfe1c9a935: Fix RELEASE-NOTES typo"
jenkins-bot [Wed, 6 Feb 2019 00:17:03 +0000 (00:17 +0000)]
Merge "resourceloader: Support TestModules registration via extension.json"
Aaron Schulz [Sun, 27 Jan 2019 21:59:59 +0000 (13:59 -0800)]
rdbms: move "maxLag" parameter up to LBFactory and add comments
Also make the default value constant be define in only one place
Change-Id: I1abd2b4569910031853b25f92d7cb69a1614d05b
James D. Forrester [Tue, 5 Feb 2019 23:28:49 +0000 (15:28 -0800)]
Follow-up
dbfe1c9a935: Fix RELEASE-NOTES typo
Change-Id: Iff1acb43b32fb8c0d64f4b59d8651d9f7decff50
Gergő Tisza [Sat, 2 Feb 2019 19:56:31 +0000 (11:56 -0800)]
Improve error handling for wrong autoloader permissions
Running Composer manually with a user different from the webserver
user and ending up with a vendor/autoload.php file that's unreadable
to MediaWiki seems like an easy mistake to make. Make the error
message when that happens less cryptic.
Change-Id: I52600adceb38a7fc5384d00b5298e46a782c684f
jenkins-bot [Tue, 5 Feb 2019 23:27:37 +0000 (23:27 +0000)]
Merge "Disallow user suppression in a partial block"
Timo Tijhof [Fri, 18 Jan 2019 20:21:35 +0000 (12:21 -0800)]
resourceloader: Support TestModules registration via extension.json
Bug: T126091
Change-Id: I27ecebe27d7aaebe6d1317bc5eaea9cca368b45d
Thalia [Mon, 14 Jan 2019 14:21:50 +0000 (14:21 +0000)]
Disallow user suppression in a partial block
Hide the "hide user" checkbox on Special:Block if the block
parameters specify a partial block. Return an error message
if a partial block with user suppression is specified via
the API. Also, make sure that an existing user suppression
is lifted if the user's block is reset to a partial block.
Bug: T210002
Change-Id: If42edfc85580d6bad6f4b397517e77e63deecc87
Roan Kattouw [Sat, 3 Nov 2018 00:53:17 +0000 (17:53 -0700)]
ResourceLoader: Add support for packageFiles
Package files are files that are part of a module, but are not
immediately executed when the module executes. Instead, they are
lazy-excecuted when require() is called on them. Package files can be
scripts (JS) or data (JSON), and can be real files on the file system,
or virtual files generated by a callback.
Using virtual data files, server-side data and config variables can be
bundled with a module. Support for file-based require() allows us to
import npm modules into ResourceLoader more easily.
The require function passed to each script execution context, which was
previously a reference to the global mw.loader.require() function, is
changed to one that is scoped to the module and the file being executed.
This is needed to support relative paths: require( '../foo.js' ) can
mean a different file depending on the path of the calling file.
The results of require()ing each file (i.e. the value of module.exports
after executing it) are stored, and calling require() on the same file a
second time won't execute it again, but will return the stored value.
Miscellaneous changes:
- Add XmlJsCode::encodeObject(), which combines an associative array of
XmlJsCode objects into one larger XmlJsCode object. This is needed for
encoding the packageFiles parameter in mw.loader.implement() calls.
Bug: T133462
Change-Id: I78cc86e626de0720397718cd2bed8ed279579112
jenkins-bot [Tue, 5 Feb 2019 21:16:08 +0000 (21:16 +0000)]
Merge "objectcache: avoid occasional test flakiness due to microtime()"
Translation updater bot [Tue, 5 Feb 2019 21:05:17 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8431d4b4bd6c05fb77390e8b850edd88509fa41d
Thalia [Tue, 5 Feb 2019 20:55:58 +0000 (20:55 +0000)]
Fix message documentation to refer to Special:Block page
Change-Id: Ib17e91c123f9f8998d2739fcb6b01c313389ea24
Umherirrender [Tue, 5 Feb 2019 19:35:05 +0000 (20:35 +0100)]
Remove deprecated class SquidUpdate
Change-Id: Iac53864296990befe7c573a29dd2f35aca52a79e
Umherirrender [Tue, 5 Feb 2019 19:04:12 +0000 (20:04 +0100)]
Move interface ICacheHelper to own class
Change-Id: I6f2b6507b0038f0988e4db5566ebddbe0d734a70
Thalia [Tue, 5 Feb 2019 17:20:58 +0000 (17:20 +0000)]
Add test for User::isBlockedFrom
In the complicated decision tree for checking if a blocked
user is blocked from their talk page, one situation was not
being tested: there's a partial block to the user talk
namespace, the block is flagged as allowing a user to edit
their talk page, BUT $wgBlockAllowsUTEdit is false. In this
circumstance, the user should be blocked from editing their
talk page, as outlined in T210475.
Also, fix whitespace and make messages clearer, since this
is now quite complicated.
Change-Id: I234f3019d55a6da0da091a2eaae6c791be01b436
jenkins-bot [Tue, 5 Feb 2019 17:49:05 +0000 (17:49 +0000)]
Merge "ApiQuerySiteinfoTest: Conversion of $wgContLang to service"
jenkins-bot [Tue, 5 Feb 2019 14:01:53 +0000 (14:01 +0000)]
Merge "Fix 'ipb_sitewide' not matching parent block after update"
jenkins-bot [Tue, 5 Feb 2019 13:29:52 +0000 (13:29 +0000)]
Merge "Add option for confirmation prompts on rollbacks"
jenkins-bot [Tue, 5 Feb 2019 10:45:42 +0000 (10:45 +0000)]
Merge "Fix grammar of "config-db-host-help""
jenkins-bot [Tue, 5 Feb 2019 09:00:42 +0000 (09:00 +0000)]
Merge "Add BeforeResetNotificationTimestamp hook"
James Montalvo [Fri, 16 Nov 2018 00:09:11 +0000 (18:09 -0600)]
Add BeforeResetNotificationTimestamp hook
Allows prevention of clearing of notification timestamp when a user
views a page in their watchlist.
Change-Id: Id0af5c89c648ac6dce80012a1566426d5552942f
jenkins-bot [Tue, 5 Feb 2019 05:44:30 +0000 (05:44 +0000)]
Merge "Move interface IJobSpecification to own file"
Aaron Schulz [Tue, 5 Feb 2019 05:35:42 +0000 (21:35 -0800)]
objectcache: avoid occasional test flakiness due to microtime()
* Fix the timestamps to static hard-coded values
* Force the timestamps before various get/set tests so they do not
use the microtime() value either.
* Remove the direct and duplicated (causing further risk) microtime()
calls from testGetWithSeveralCheckKeys().
Bug: T207247
Change-Id: Id30a8127f11501dbe54e075b6e9d18490353f4a5
Fomafix [Tue, 5 Feb 2019 03:52:00 +0000 (04:52 +0100)]
ApiQuerySiteinfoTest: Conversion of $wgContLang to service
Bug: T200246
Change-Id: Ibdf07adc7a4cf28f0f9f48f18985651a379bc10c
jenkins-bot [Tue, 5 Feb 2019 02:14:14 +0000 (02:14 +0000)]
Merge "Display translatable images in wiki language on image pages"
jenkins-bot [Tue, 5 Feb 2019 01:33:00 +0000 (01:33 +0000)]
Merge "specialpage: Fix login crash caused by unknown language via ?uselang"
Max Semenik [Wed, 9 Jan 2019 20:48:02 +0000 (12:48 -0800)]
Display translatable images in wiki language on image pages
We currently show SVGs in default languages unless overridden with
lang=... URL parameter (and we have UI for setting it). This change
makes it display thumbnails in wiki language, if translation is available.
Bug: T210814
Change-Id: Ieb0b5e9e27f45b71ef119bb3c1d3f2cd4d7100e5
Dayllan Maza [Mon, 4 Feb 2019 22:31:55 +0000 (17:31 -0500)]
Fix 'ipb_sitewide' not matching parent block after update
Autoblocks ipb_sitewide was not being updated when changing the parent
block from sitewide to partial and vice-versa
Bug: T215205
Change-Id: Ied5a8361a733c47f0afea78cc955732261ede446
Translation updater bot [Mon, 4 Feb 2019 20:56:39 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib354beb08668e1afe72246f382dc9e4396e96fea
Umherirrender [Mon, 4 Feb 2019 20:00:06 +0000 (21:00 +0100)]
Move interface IJobSpecification to own file
Change-Id: Iabb10f8473b2ef0f4aea2aaca0dad39745028ece
jenkins-bot [Mon, 4 Feb 2019 19:44:36 +0000 (19:44 +0000)]
Merge "Remove unused apihelp-createaccount messages"
Umherirrender [Mon, 4 Feb 2019 18:53:57 +0000 (19:53 +0100)]
Remove unused apihelp-createaccount messages
Unused since I2b2c9693a275fcc026916bd97f303e7a5c8df341
Change-Id: Iaaadaef063ead5d2aa30d4e943ba72e4f4dfbf9a
Thiemo Kreuz [Wed, 9 Jan 2019 15:49:25 +0000 (16:49 +0100)]
Use shorter ?: syntax in Revision class
This is semantically the same because the returned object can't be
anything but an object (which can never be false), or null. Personlly,
I find the more expressive "=== null" check does not help here, but
makes the code a little harder to read.
Change-Id: Ib7390a7680f24fec7f5b9cea716603c14ad3f2dd
jenkins-bot [Mon, 4 Feb 2019 17:57:06 +0000 (17:57 +0000)]
Merge "Added future compat expectException to PHPUnit4And6Compat trait"
jenkins-bot [Mon, 4 Feb 2019 17:57:00 +0000 (17:57 +0000)]
Merge "Prevent undesired toggling on Special:NewPages"
Tim Eulitz [Mon, 4 Feb 2019 15:32:52 +0000 (16:32 +0100)]
Add option for confirmation prompts on rollbacks
By default this option will be enabled in core, however, the option will
be overriden by a separate commit to mediawiki-config where it will be
disabled for all wikis for now.
Bug: T215019
Change-Id: I73f060fc954abb6ec02238b16c8598dd6ebd4ae4
Leszek Manicki [Wed, 30 Jan 2019 16:55:18 +0000 (17:55 +0100)]
Added future compat expectException to PHPUnit4And6Compat trait
This allows PHPUnit 6 ready tests asserting
the exception that is to be thrown (as setExpectedException
is removed in PHPUnit 6).
Bug: T208389
Change-Id: I13c58f37671092583a7fdfed7ccee9c2a4ecb136
jenkins-bot [Mon, 4 Feb 2019 10:08:04 +0000 (10:08 +0000)]
Merge "watcheditem: Replace error message strings with constant string"
jenkins-bot [Mon, 4 Feb 2019 07:03:56 +0000 (07:03 +0000)]
Merge "Equialization of Serbian Latin translations with Serbian Cyrillic translations"
jenkins-bot [Sun, 3 Feb 2019 22:04:26 +0000 (22:04 +0000)]
Merge "objectcache: avoid duplicate set() calls with lockTSE when no value is in cache"
Translation updater bot [Sun, 3 Feb 2019 20:56:18 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic00ccbd3487d1861d3196670792ec529d1f81f73
jenkins-bot [Sun, 3 Feb 2019 20:28:49 +0000 (20:28 +0000)]
Merge "Add @coversNothing for left over tests and enable sniff"
jenkins-bot [Sun, 3 Feb 2019 20:28:43 +0000 (20:28 +0000)]
Merge "Add some missing @covers tags"
jenkins-bot [Sun, 3 Feb 2019 17:55:10 +0000 (17:55 +0000)]
Merge "Title: Add null to @return type for getSubpage"
Fomafix [Sun, 3 Feb 2019 17:08:40 +0000 (18:08 +0100)]
Title: Add null to @return type for getSubpage
Title::makeTitleSafe can return null on an invalid title. Therefor
Title::getSubpage can also return null on an error.
Change-Id: I8f7d5125bd8bd609b6120b0f7682c6e519063476
Fomafix [Wed, 30 Jan 2019 20:24:06 +0000 (21:24 +0100)]
Fix @param tags
* Use 'callable' instead of 'callback'.
* Remove '$' as part of a type name.
* Add missing type.
Change-Id: Ic1b39a7d8cbbee000d8fb2f3a1f71a621bd01993
Matěj Suchánek [Sun, 3 Feb 2019 12:17:04 +0000 (13:17 +0100)]
Prevent undesired toggling on Special:NewPages
Bug: T211549
Change-Id: I09928674c66a6359a417a221049259cb318dd00a
Kunal Mehta [Sun, 3 Feb 2019 05:42:31 +0000 (21:42 -0800)]
Finish FormatJson::encode() test coverage
Change-Id: I3aced17da653216de2092e1d7986748c271c5b82
Umherirrender [Fri, 1 Feb 2019 19:46:59 +0000 (20:46 +0100)]
Add @coversNothing for left over tests and enable sniff
LessFileCompilationTest is checking less files for valid syntax
doc test is checking xml file for valid syntax
MediaWikiTest is testing a complex situation with many functions involved
SideBarTest is self checking, needs no coverage
structure tests not covers functions, there are covers global structures
Change-Id: I3ac65db561cae0be8418aa9c830e7a9f46ad11fe
Kunal Mehta [Wed, 30 Jan 2019 08:23:48 +0000 (00:23 -0800)]
Add some missing @covers tags
Change-Id: Idb9af9515702ee9748755d7799663713b2283647
Aaron Schulz [Sun, 3 Feb 2019 02:13:17 +0000 (18:13 -0800)]
objectcache: avoid duplicate set() calls with lockTSE when no value is in cache
Each thread will still run the callback, but only one will save the value back
Bug: T203786
Change-Id: Idc4738aa005cc44ec0f1adc6dcf2e3f87d0c9480
jenkins-bot [Sat, 2 Feb 2019 23:44:56 +0000 (23:44 +0000)]
Merge "Add missing @covers to media related tests"
jenkins-bot [Sat, 2 Feb 2019 23:39:36 +0000 (23:39 +0000)]
Merge "Add missing @covers to revision related tests"
jenkins-bot [Sat, 2 Feb 2019 23:39:32 +0000 (23:39 +0000)]
Merge "Add missing @covers to search related tests"
jenkins-bot [Sat, 2 Feb 2019 23:25:48 +0000 (23:25 +0000)]
Merge "Add missing @covers to action related tests"
jenkins-bot [Sat, 2 Feb 2019 23:25:42 +0000 (23:25 +0000)]
Merge "Add missing @covers to user related tests"
jenkins-bot [Sat, 2 Feb 2019 23:20:26 +0000 (23:20 +0000)]
Merge "Add missing @covers to backend related tests"
jenkins-bot [Sat, 2 Feb 2019 23:20:21 +0000 (23:20 +0000)]
Merge "Add missing @covers to parser related tests"
jenkins-bot [Sat, 2 Feb 2019 23:15:49 +0000 (23:15 +0000)]
Merge "Add missing @covers to database related tests"
jenkins-bot [Sat, 2 Feb 2019 21:44:50 +0000 (21:44 +0000)]
Merge "build: Update eslint-config-wikimedia to 0.10.1"
Thalia [Sat, 2 Feb 2019 04:47:58 +0000 (20:47 -0800)]
Prevent special block test failures with certain configs
The checkbox for preventing a user from editing their own talk
page is only present for partial blocks if wgBlockAllowsUTEdit
is true, so set it to true for any tests that check for its
presence.
Change-Id: I0228f5787ad17130cbe015641c1142a7e52cef38
Ed Sanders [Sat, 2 Feb 2019 19:05:04 +0000 (11:05 -0800)]
build: Update eslint-config-wikimedia to 0.10.1
Change-Id: Id98af16c1ec1c6c4a790948a35e96e2fe925ebb5
Zoranzoki21 [Sat, 2 Feb 2019 15:35:29 +0000 (16:35 +0100)]
Equialization of Serbian Latin translations with Serbian Cyrillic translations
This was done already before at I3c79ded77f16beee404ca3005ae7678838ab9d60
Change-Id: I09e704d3051a6177f5f41eff8c8085e85ef4e02a
jenkins-bot [Sat, 2 Feb 2019 04:14:07 +0000 (04:14 +0000)]
Merge "Preload styles for 'jquery.tablesorter'"
jenkins-bot [Fri, 1 Feb 2019 21:40:14 +0000 (21:40 +0000)]
Merge "Soft deprecate QuickTemplate::msgWiki()"
jenkins-bot [Fri, 1 Feb 2019 21:38:42 +0000 (21:38 +0000)]
Merge "Move interface ILocalizedException to own file"
jenkins-bot [Fri, 1 Feb 2019 21:35:43 +0000 (21:35 +0000)]
Merge "Check for intl extension in updateCredits.php"
Umherirrender [Fri, 1 Feb 2019 20:57:58 +0000 (21:57 +0100)]
Add missing @covers to search related tests
Change-Id: Iba122ad763a5728a7ddb487b3d01d679de6845e5
Thiemo Kreuz [Mon, 14 Jan 2019 13:43:29 +0000 (14:43 +0100)]
Soft deprecate QuickTemplate::msgWiki()
This method just should not exist. It does have a bad name that does not
say much about what it does and how it is supposed to be used. And it
does horrible things: it accesses the global $wgOut, which currently
results in test failures, see
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/15200/console
Note how it was marked as @private, which is honorable, but doesn't
work for multiple reasons. First, an overload exists in the BaseTemplate
subclass. Second, calls from external code exist. Third, if it would be
really private, it could as well be deleted, because there is no private
caller.
Luckily the number of callers is extremely close to zero, see
https://codesearch.wmflabs.org/search/?q=>msgWiki%5C(
A patch for the Collection extension already exists.
Change-Id: I8d2c14f10fbf314735d1aa82bdc8edfb4fa9a0dd
Umherirrender [Fri, 1 Feb 2019 19:44:21 +0000 (20:44 +0100)]
Add missing @covers to user related tests
Change-Id: Icebd692a37108e3c637648213896ededa588cecd
Umherirrender [Fri, 1 Feb 2019 20:34:31 +0000 (21:34 +0100)]
Add missing @covers to media related tests
Change-Id: Ideb4fcf4e0c55c3720557b3d93eec06f671b3fd9
Umherirrender [Fri, 1 Feb 2019 20:48:33 +0000 (21:48 +0100)]
Add missing @covers to parser related tests
Change-Id: I615ba41c9a6f235f65991549cb27003438115fe9
Umherirrender [Fri, 1 Feb 2019 19:53:33 +0000 (20:53 +0100)]
Add missing @covers to revision related tests
Change-Id: Id95369208e988c16d626ca6f986898e3e84e8565
Umherirrender [Fri, 1 Feb 2019 21:13:32 +0000 (22:13 +0100)]
Add missing @covers to action related tests
Change-Id: I7653b5fa6f6a3c247f735ac22fda12e7c9549786
Umherirrender [Fri, 1 Feb 2019 21:08:32 +0000 (22:08 +0100)]
Add missing @covers to backend related tests
Change-Id: I6ecbedf7d4f6c48b4f17331c31588f2c8b772054
Umherirrender [Fri, 1 Feb 2019 19:59:16 +0000 (20:59 +0100)]
Add missing @covers to database related tests
Change-Id: I370275bb6c5d456b73f6a5f782e231f16c2b0fbe
jenkins-bot [Fri, 1 Feb 2019 19:08:36 +0000 (19:08 +0000)]
Merge "Remove require_once from maintenance tests"
Umherirrender [Fri, 1 Feb 2019 19:05:30 +0000 (20:05 +0100)]
Move interface ILocalizedException to own file
Change-Id: I66429a89633a74a22999775214aa23ae189b837e
Umherirrender [Fri, 1 Feb 2019 18:57:56 +0000 (19:57 +0100)]
Check for intl extension in updateCredits.php
Change-Id: Ifa2892b2f38fa73362c3ac60e1d90614cdbc0a93
Umherirrender [Fri, 1 Feb 2019 18:45:12 +0000 (19:45 +0100)]
Remove require_once from maintenance tests
class FetchText and TextPassDumper part of autoloader
Change-Id: I307a9ac002d09e8fe05385e57d525055f5cb0b8a
Umherirrender [Fri, 1 Feb 2019 18:40:22 +0000 (19:40 +0100)]
Rename CategoryChangesRdfTest to match maintenance script
Change-Id: Ib0ab880653f90df608d89a5f85c9949b380abe33
Derick Alangi [Fri, 1 Feb 2019 15:55:29 +0000 (16:55 +0100)]
watcheditem: Replace error message strings with constant string
As the messages are the same and in addition using the same class
DBReadOnlyError, make the error message a constant and pass it as
self::DB_READONLY_ERROR argument to this class. Changing the error
will apply to the class as intended rather than change it in each
single place that this string appears.
Change-Id: I7f978cc334020746b4c4405fa2a0a73219bdacac